Uhm. Rock Band all the way.
Nothing can beat its DLC, its attention to detail, and its ability to actually learn instruments.
Of course, you do know the guys that created Rock Band (Harmonix) were the original designers of Guitar Hero and created Rock Band when they were ousted from their game by Activision. Everything Neversoft Guitar Hero sucks balls.